Fix remaining RSpec/LetSetup cops
#28368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
requested changes
Dec 19, 2023
| @@ -14,7 +14,6 @@ | |||
|
|
|||
| describe 'GET #index' do | |||
| let(:scopes) { 'read:filters' } | |||
| let!(:filter) { Fabricate(:custom_filter, account: user.account) } | |||
There was a problem hiding this comment.
We most likely want to still create an object for this test case
| @@ -152,7 +152,7 @@ | |||
| context 'with follows' do | |||
| let(:import_type) { 'following' } | |||
|
|
|||
| let!(:rows) do | |||
| before do | |||
| [ | |||
| { 'acct' => 'foo@bar' }, | |||
| { 'acct' => 'user@bar', 'show_reblogs' => false, 'notify' => true, 'languages' => %w(fr de) }, | |||
There was a problem hiding this comment.
Line below should be an each? Same remark throughout that file.
|
Honestly, I feel like in some cases it splits the test data definitions in ways that make them less readable |
|
Closing this in favor of submitting smaller PRs -- and I'm also going to do a pass through the whole thing where I add checks that actually do use the currently unused vars, where that makes sense. Will get through that and see what's left. |
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff lengthy, but fortunately theres only 1-2 changes in most of the files. Changes in a few categories:
let!that could have been in abeforeor right in the example, so I just moved them in.sendwith a symbol so it was seen as not used. This struck me as more confusing than useful in terms of the compactness, so I unrolled the loop into multiple examples.letand added the usage