Add a missing spec to SessionsController#webauthn_options
#29277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not enabled on a user There was a missing test [1] for SessionsController#webauthn_options for when webauthn is not enabled on a user. [1] https://app.codecov.io/gh/mastodon/mastodon/pull/29158/blob/app/controllers/auth/sessions_controller.rb#L61
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29277 +/- ##
==========================================
- Coverage 85.01% 85.01% -0.01%
==========================================
Files 1059 1060 +1
Lines 28277 28312 +35
Branches 4538 4542 +4
==========================================
+ Hits 24040 24069 +29
- Misses 3074 3076 +2
- Partials 1163 1167 +4 ☔ View full report in Codecov by Sentry. |
renchap
added
testing
mjankowski
approved these changes
Feb 19, 2024
ClearlyClaire
approved these changes
Feb 26, 2024
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Feb 27, 2024
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Mar 19, 2024
lutoma
pushed a commit
to ohaisocial/mastodon
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing test [1] for
SessionsController#webauthn_optionsfor when webauthn is not enabled on a user. This PR will make sure that the 401 Error is rendered in the Test suite.[1] https://app.codecov.io/gh/mastodon/mastodon/pull/29158/blob/app/controllers/auth/sessions_controller.rb#L61