Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When posting a single image, it is possible to effectively deny service #29310

Open
BNolet opened this issue Feb 21, 2024 · 3 comments
Open

When posting a single image, it is possible to effectively deny service #29310

BNolet opened this issue Feb 21, 2024 · 3 comments
Labels
area/web interface Related to the Mastodon web interface bug Something isn't working status/to triage This issue needs to be triaged

Comments

@BNolet
Copy link

BNolet commented Feb 21, 2024

Steps to reproduce the problem

  1. Post image that is 10000px tall and 0-10px wide
  2. The preview of the image is rendered in full length, taking up a HUGE portion of someone's timeline.
  3. Rinse and repeat to effectively deny service

This will also mean that the buttons needing to be accessed to block the person will be hidden waaaay at the bottom of the post that includes the 10000px tall image.

Expected behaviour

The image should render with a sane maximum height/length

Actual behaviour

The image is rendered in full height/length

Detailed description

No response

Mastodon instance

fosstodon.org

Mastodon version

v4.2.7

Browser name and version

122.0.1

Operating system

macOS 14.3.1

Technical details

No response

@BNolet BNolet added area/web interface Related to the Mastodon web interface bug Something isn't working status/to triage This issue needs to be triaged labels Feb 21, 2024
@cphuntington97
Copy link

Just want to confirm that the test post rendered as described on Mastodon 4.2.7 viewed in Firefox 123 on Windows 10 as well.

@MadokVaur
Copy link

This popped up in my Mastodon alerts email and I spent way too much time trying to figure out how an aspect ratio could be "too small"

Going to Wikipedia, we see "a ratio shows how many times one number contains another."

So would a ratio that is "too small" be a 1:1 ratio? That's about as "small" a ratio that I can think of

Perhaps this should be re-written as "ratios that are too disparate between their two elements" i.e. 1:10000?

With all due respect I don't think this is merely quibbling about semantics

@BNolet
Copy link
Author

BNolet commented Apr 5, 2024

Regardless of the description required, the code seems to reflect the fix needed for the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web interface Related to the Mastodon web interface bug Something isn't working status/to triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants