Convert the streaming server to ESM #29389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29389 +/- ##
==========================================
+ Coverage 85.01% 85.10% +0.08%
==========================================
Files 1059 1062 +3
Lines 28277 28352 +75
Branches 4538 4548 +10
==========================================
+ Hits 24040 24129 +89
+ Misses 3074 3061 -13
+ Partials 1163 1162 -1 ☔ View full report in Codecov by Sentry. |
This is supported by Node 16+ Some notes: - `__dirname` does not work in ES modules, but you can get the same result - `delete session` was a no-op, because `delete` can only operate on object properties. Using ESM forces strict-mode, which fails at parsing on this rather than silently ignoring the statement. Added a comment to fix this in a future refactor. - eslint does not support yet ESM configs (this will be supported in eslint 9), so the file has been kept as cjs
renchap
force-pushed
the
streaming-to-esm
branch
from
0cbc5b3
to
c63f975
Compare
ykzts
previously approved these changes
Feb 27, 2024
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
ClearlyClaire
approved these changes
Feb 27, 2024
lutoma
pushed a commit
to ohaisocial/mastodon
that referenced
this pull request
Mar 19, 2024
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supported by Node 16+
Some notes:
__dirnamedoes not work in ES modules, but you can get the same resultdelete sessionwas a no-op, becausedeletecan only operate on object properties. Using ESM forces strict-mode, which fails at parsing on this rather than silently ignoring the statement. Added a comment to fix this in a future refactor.