Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IpBlock model test coverage #29460

Merged
merged 2 commits into from Mar 1, 2024

Conversation

danielmbrasil
Copy link
Contributor

Adds tests for the model validations, class method and callback.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (86500e3) to head (a59d0cc).
Report is 194 commits behind head on main.

❗ Current head a59d0cc differs from pull request most recent head 7793529. Consider uploading reports for the commit 7793529 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29460      +/-   ##
==========================================
+ Coverage   85.01%   85.10%   +0.08%     
==========================================
  Files        1059     1062       +3     
  Lines       28277    28352      +75     
  Branches     4538     4548      +10     
==========================================
+ Hits        24040    24129      +89     
+ Misses       3074     3061      -13     
+ Partials     1163     1162       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renchap renchap added testing Automated lint and test suites ruby Pull requests that update Ruby code labels Feb 29, 2024
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution!

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Mar 1, 2024
Merged via the queue into mastodon:main with commit a25014d Mar 1, 2024
29 checks passed
@danielmbrasil danielmbrasil deleted the test/model-ip-block branch March 1, 2024 16:23
lutoma pushed a commit to ohaisocial/mastodon that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code testing Automated lint and test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants