Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic message for failure during CLI search deploy #29462

Merged
merged 2 commits into from Mar 15, 2024

Conversation

mjankowski
Copy link
Contributor

Related #28673

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (86500e3) to head (3a55c2b).
Report is 241 commits behind head on main.

❗ Current head 3a55c2b differs from pull request most recent head 5433448. Consider uploading reports for the commit 5433448 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29462      +/-   ##
==========================================
+ Coverage   85.01%   85.10%   +0.09%     
==========================================
  Files        1059     1062       +3     
  Lines       28277    28353      +76     
  Branches     4538     4548      +10     
==========================================
+ Hits        24040    24131      +91     
+ Misses       3074     3061      -13     
+ Partials     1163     1161       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjankowski mjankowski requested a review from a team March 14, 2024 20:01
@mjankowski mjankowski added bug Something isn't working ruby Pull requests that update Ruby code labels Mar 14, 2024
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this could obscure the exact error, but also the linked issue is an example of a particularly obscure error…

@mjankowski
Copy link
Contributor Author

I'm afraid this could obscure the exact error

Updated to preserve original error message/backtrace.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Mar 15, 2024
Merged via the queue into mastodon:main with commit 4f4132f Mar 15, 2024
29 checks passed
@mjankowski mjankowski deleted the cli-search-setup-error branch March 15, 2024 14:49
lutoma pushed a commit to ohaisocial/mastodon that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants