Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribution to Tabler.io icons used in the new mailer designs #29470

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ClearlyClaire
Copy link
Contributor

This moves some files to a different directory, thus breaking their usage in mails, but only mails from the very last commit would use them.

@ClearlyClaire ClearlyClaire marked this pull request as ready for review March 1, 2024 12:47
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Mar 1, 2024
@mjankowski
Copy link
Contributor

Side note to this change -- is it correct at this point that all the mailers have been converted and are using the new layout, assets, etc? -- and if so, we can probably a) delete the old unused mailer-only assets, b) rename the mailer-new to just mailer or whatever once the old stuff is gone?

Merged via the queue into main with commit 1d721b2 Mar 1, 2024
46 checks passed
@ClearlyClaire ClearlyClaire deleted the fixes/tabler-icons branch March 1, 2024 14:56
@renchap
Copy link
Sponsor Member

renchap commented Mar 1, 2024

Side note to this change -- is it correct at this point that all the mailers have been converted and are using the new layout, assets, etc? -- and if so, we can probably a) delete the old unused mailer-only assets, b) rename the mailer-new to just mailer or whatever once the old stuff is gone?

Yes, I think they have all been converted.

But we probably want to keep the old assets, at least for some time, because they might have been referenced in old emails, and if people run clobber (or the docker image), it would make them 404.

lutoma pushed a commit to ohaisocial/mastodon that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants