Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RSpec/DescribedClass cop #29472

Merged
merged 1 commit into from Mar 13, 2024
Merged

Fix RSpec/DescribedClass cop #29472

merged 1 commit into from Mar 13, 2024

Conversation

mjankowski
Copy link
Contributor

Related to #29466

@mjankowski mjankowski force-pushed the rubocop-rspec-described-class branch from 15f3306 to e335dd1 Compare March 12, 2024 14:58
@mjankowski mjankowski requested a review from a team March 12, 2024 17:37
ClearlyClaire
ClearlyClaire approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but honestly, I don't think the change brings much, and Rubocop updates having us make pointless changes like this is why I'm not perfectly comfortable with Rubocop in the first place.

@mjankowski
Copy link
Contributor Author

Looks ok, but honestly, I don't think the change brings much, and Rubocop updates having us make pointless changes like this is why I'm not perfectly comfortable with Rubocop in the first place.

My personal belief is that almost every ruby project should delete all of their rubocop configuration, replace it with standard, follow those guidelines, and never talk about it again.

Short of that, on a project with a rubocop config, I think it's best to accept your fate, and like Sisyphus pushing the boulder up the mountain, proactively and aggressively deal with all the issues, using ignoreRevsFile locally for anyone who cares to.

@ClearlyClaire
Copy link
Contributor

The issue is that this increases the maintenance burden of older versions, as backporting fixes may involve tripping on rubocop-related code changes.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Mar 13, 2024
Merged via the queue into mastodon:main with commit 6262cee Mar 13, 2024
27 checks passed
@mjankowski mjankowski deleted the rubocop-rspec-described-class branch March 13, 2024 16:11
lutoma pushed a commit to ohaisocial/mastodon that referenced this pull request Mar 19, 2024
@mjankowski @lutoma
Fix RSpec/DescribedClass cop (mastodon#29472)
4a92609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjankowski @ClearlyClaire