Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Api::ErrorHandling concern for api/base controller #29574

Merged

Conversation

mjankowski
Copy link
Contributor

This is a subset of #27925

  • Includes JUST the extraction of the error handling methods into a concern, with zero modification to the controller code and as small a change as I could think of to the spec
  • Does not include the i18n changes, the string method changes, or the spec refactor (to add response message check in addition to code checks) from the original

Will rebase that other and continue to pull out anything valuable (I think at least the string check in the specs is useful, even if the i18n and string method are not desired) from it if this is merged.

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Mar 14, 2024
Merged via the queue into mastodon:main with commit f910074 Mar 14, 2024
29 checks passed
@mjankowski mjankowski deleted the api-errors-concern-no-strings branch March 14, 2024 13:02
lutoma pushed a commit to ohaisocial/mastodon that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants