New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use composable query in `User.active` scope #29775

Merged

ClearlyClaire merged 1 commit into mastodon:main from mjankowski:more-scopes-user-ones

Apr 8, 2024

Contributor

mjankowski commented Mar 27, 2024

Collection of related changes:

Consolidate the repeated queries around users signed in recently to a signed_in_recently scope
Rename inactive to not_signed_in_recently to more narrowly reflect what it does (because there's also an active and they are not opposites)
Compose the User.active scope from smaller well-named scopes for readability at a glance to see what concepts "active" is made of
Spec coverage for the added scopes, and update the renamed


          Use composable query in User.active scope

19132dd

mjankowski mentioned this pull request

Add User.recently_active scope #29615

Closed

ClearlyClaire approved these changes

View reviewed changes

ClearlyClaire added this pull request to the merge queue

Merged via the queue into mastodon:main with commit 285f63c

32 checks passed

mjankowski deleted the more-scopes-user-ones branch

April 8, 2024 14:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment