Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
active
scope was also repeating this logic, so replace it with the new scope.inactive
to match style of new scope since they are oppositesI believe this brings all references to the active duration constant back into User class. Other than changed quoting on the generated queries from the framework, the generated sql for the existing usage is the same.
Possible future thing here -- I did not look at how much usage of the existing
active
scope there is. The name here is sort of misleading, but something likeconfirmed_and_recently_active_and_account_not_suspended
is excessive. Maybe there's a better alternative.