Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency selenium-webdriver to v4.19.0 #29776

Merged
merged 2 commits into from Apr 2, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 27, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
selenium-webdriver (source, changelog) 4.18.1 -> 4.19.0 age adoption passing confidence

Release Notes

SeleniumHQ/selenium (selenium-webdriver)

v4.19.0

Compare Source

=========================

  • Add CDP for Chrome 123 and remove 120
  • Avoid over-escaping browser path (#​13632)
  • Add full RBS support (#​13234)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Mar 27, 2024
@mjankowski
Copy link
Contributor

Along with merging this, we may want to review the chrome version setting that we had in place for the intermittent CI failures a while back (release notes here indicate chrome 123 CDP support).

@ClearlyClaire
Copy link
Contributor

We use options.browser_version = '120' and the changelog says they've removed 120… yet the tests succeed. I'm not sure what this means. But we can try dropping that setting and see how it goes.

Copy link
Contributor Author

renovate bot commented Mar 28, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@ClearlyClaire
Copy link
Contributor

Removed the version specification, re-ran the tests a bunch of time, and ended up only seeing one error that seem consistent with the flaky tests we've been having without this PR. So I don't think there's any regression and this is good to merge.

@ClearlyClaire ClearlyClaire requested a review from a team April 2, 2024 08:37
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 589e34d Apr 2, 2024
33 checks passed
@ClearlyClaire ClearlyClaire deleted the renovate/selenium-webdriver-4.x-lockfile branch April 2, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants