Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stub for trending tags in user mailer spec #29850

Merged
merged 1 commit into from Apr 5, 2024
Merged

Add stub for trending tags in user mailer spec #29850

merged 1 commit into from Apr 5, 2024

Conversation

ClearlyClaire
Copy link
Contributor

Not completely satisfied with it, but it extends coverage and would have caught #29847

@ClearlyClaire ClearlyClaire added the testing Automated lint and test suites label Apr 4, 2024
mjankowski
mjankowski approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@mjankowski mjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely better than nothing.

Possible future improvement would be to shorten up the method called from the mailer so the stubbing is more targeted (like Tag.for_welcome_mailer or Trends.onboarding_tags or whatever naming wise)

@ClearlyClaire ClearlyClaire added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 1f11aa5 Apr 5, 2024
54 checks passed
@ClearlyClaire ClearlyClaire deleted the tests/stub-trending-tags branch April 5, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjankowski mjankowski mjankowski approved these changes

@renchap renchap renchap approved these changes

Assignees
No one assigned
Labels
testing Automated lint and test suites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClearlyClaire @mjankowski @renchap