Use public_visibility

[tribela]

Related: #28156

with_public_visibility was removed. So ActionView::Template::Error caused.

[renchap]

Woops, good catch!

I would have expected the email one to have bet caught by a test, this looks like a pretty big gap in coverage :( @mjankowski was this on your radar?

[ClearlyClaire]

This hasn't been caught by tests because this code path is only triggered for trending tags, which the tests do not include. Those are unfortunately tricky to stub.

[mjankowski]

Both of these usages were added after the PR that removed the method, so I hadn't removed them there since they didn't exist yet.

Looks like the entire annual report area has zero spec coverage, and as Claire notes there are many portions of views/mailers/etc where even if we hit the high level methods we don't hit every single path through them (and yes, I'd say that's vaugely on my radar, but there's just a ton missing so it's slow going).

Glad we caught this in nightly usage before a release.