Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inert polyfill #6053

Closed
sorin-davidoi opened this issue Dec 16, 2017 · 1 comment
Closed

Use inert polyfill #6053

sorin-davidoi opened this issue Dec 16, 2017 · 1 comment
Labels
accessibility Screen readers and related bug Something isn't working fit for beginners Low-hanging fruit

Comments

@sorin-davidoi
Copy link
Contributor

sorin-davidoi commented Dec 16, 2017 •
edited
Loading

Since #4405 we are using the inert attribute for accessibility reasons in the modals. However, this is currently only supported in Google Chrome.

There are two polyfills which we can use:

I would prefer the official one but we need to look into the performance penalty.
@sorin-davidoi sorin-davidoi added accessibility Screen readers and related bug Something isn't working fit for beginners Low-hanging fruit labels Dec 16, 2017
@gabrielrumiranda gabrielrumiranda mentioned this issue Oct 25, 2019
Merged
@SuperSandro2000
Copy link
Contributor

SuperSandro2000 commented Feb 13, 2020 •
edited
Loading

#12209 closes this issue.

@ykzts ykzts closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Screen readers and related bug Something isn't working fit for beginners Low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ykzts @sorin-davidoi @SuperSandro2000