Improve accessibility (part 3) #4405
Conversation
|
I think the warnings are wrong? |
|
Looks like it was fixed last month? https://github.com/evcohen/eslint-plugin-jsx-a11y/releases/tag/v6.0.0 |
| @@ -133,15 +135,15 @@ export default class ColumnHeader extends React.PureComponent { | |||
|
|
|||
| return ( | |||
| <div className={wrapperClassName}> | |||
| <div role='heading' tabIndex={focusable && '0'} className={buttonClassName} aria-label={title} onClick={this.handleTitleClick}> | |||
| <h1 role='heading' tabIndex={focusable && '0'} className={buttonClassName} aria-label={title} onClick={this.handleTitleClick}> | |||
There was a problem hiding this comment.
It's heading element now, so role='heading' can be removable.
Hwhat? |
|
I've added the |
|
<3 you're the best sorin |
* fix(compose): Add aria-label for the navigation links * fix(search): Add input label * fix(navigation_bar): Link description * fix(autosuggest_textarea): Add input label * fix(compose_form): Add input label * fix(upload_button): Add input label * fix(account/header): Add link content * fix(column_header): Use h1 tag * fix(column_header): Labels move buttons moving column * fix(settings_text): Add label to input * fix(column_header): Remove role from h1 * fix(modal_root): Use role=dialog * fix(modal_root): Focus restauration * fix(modal_root): Apply inert to sibligs * fix(column_header): Add role=button * chore(eslint): Disable jsx-a11y/label-has-for
Follow-up to #4369 and #4377. Mostly fixes errors discovered by WAVE Web Accessibility Tool.
cc: @yiskah