Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresolved reply visibility #614

Closed
Gargron opened this issue Feb 9, 2017 · 0 comments
Closed

Unresolved reply visibility #614

Gargron opened this issue Feb 9, 2017 · 0 comments

Comments

@Gargron
Copy link
Member

Gargron commented Feb 9, 2017

Solution: Instead of the reply? method being defined on the Status class from checking if in_reply_to_id was set, create reply as an explicit boolean field on the table. In before_validation, do the in_reply_to_id-based setting of it, unless it has already been set. In ProcessFeedService, set it to true explicitly when a thr:in-reply-to element is found.

Some filtering code may need to be adjusted for the case that thread is nil, and public timelines queries need to be adjusted to check reply = false instead of in_reply_to_id IS NULL. Anyway, the reason this will work is the following:

If, when a status comes in, the status it replies to is not in the system already, that means nobody on the system follows the user being replied to. The home feed filters out replies to people the user doesn't follow. Ergo, statuses for which it's known that it's a reply, but not known what is being replied to, can be filtered out straight away. This will fix lots of confusion about replies showing up on feeds sometimes.

@Gargron Gargron closed this as completed in 6331ed1 Feb 9, 2017
Nyoho referenced this issue in Nyoho/mathtodon Apr 25, 2017
…replied-to

status is not in the system at time of distribution; fix #607 - reset privacy
settings to defaults when cancelling replies
abcang added a commit to pixiv/mastodon that referenced this issue Aug 22, 2017
…ed_users

Move clean up of unconfirmed users to sidekiq-scheduler (mastodon#4336)
abcang added a commit to pixiv/mastodon that referenced this issue Aug 23, 2017
…ed_users

Move clean up of unconfirmed users to sidekiq-scheduler (mastodon#4336)
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this issue Jul 30, 2018
Merge upstream changes up to (excluding) profile redesign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant