-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unresolved reply visibility #614
Comments
Nyoho
referenced
this issue
in Nyoho/mathtodon
Apr 25, 2017
…replied-to status is not in the system at time of distribution; fix #607 - reset privacy settings to defaults when cancelling replies
abcang
added a commit
to pixiv/mastodon
that referenced
this issue
Aug 22, 2017
…ed_users Move clean up of unconfirmed users to sidekiq-scheduler (mastodon#4336)
abcang
added a commit
to pixiv/mastodon
that referenced
this issue
Aug 23, 2017
…ed_users Move clean up of unconfirmed users to sidekiq-scheduler (mastodon#4336)
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this issue
Jul 30, 2018
Merge upstream changes up to (excluding) profile redesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Solution: Instead of the
reply?
method being defined on the Status class from checking ifin_reply_to_id
was set, createreply
as an explicit boolean field on the table. Inbefore_validation
, do thein_reply_to_id
-based setting of it, unless it has already been set. In ProcessFeedService, set it to true explicitly when athr:in-reply-to
element is found.Some filtering code may need to be adjusted for the case that
thread
is nil, and public timelines queries need to be adjusted to checkreply = false
instead ofin_reply_to_id IS NULL
. Anyway, the reason this will work is the following:If, when a status comes in, the status it replies to is not in the system already, that means nobody on the system follows the user being replied to. The home feed filters out replies to people the user doesn't follow. Ergo, statuses for which it's known that it's a reply, but not known what is being replied to, can be filtered out straight away. This will fix lots of confusion about replies showing up on feeds sometimes.
The text was updated successfully, but these errors were encountered: