Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO account creation fails with "Agreement must be accepted" #9906

Closed
ineffyble opened this issue Jan 22, 2019 · 2 comments
Closed

SSO account creation fails with "Agreement must be accepted" #9906

ineffyble opened this issue Jan 22, 2019 · 2 comments

Comments

@ineffyble
Copy link
Member

ineffyble commented Jan 22, 2019

Since upgrading, new users coming via SSO have not had new accounts created, and instead received a 422.

Looking in the logs, we see:

I, [2019-01-22T15:01:37.442903 #9]  INFO -- omniauth: (saml) Callback phase initiated.
[47653726-2c14-4441-83f6-11f8cf91073f] method=POST path=/auth/auth/saml/callback format=html controller=Auth::OmniauthCallbacksController action=saml status=422 error='ActiveRecord::RecordInvalid: Validation failed: Agreement must be accepted' duration=203.69 view=0.00 db=43.69
[47653726-2c14-4441-83f6-11f8cf91073f]   
[47653726-2c14-4441-83f6-11f8cf91073f] ActiveRecord::RecordInvalid (Validation failed: Agreement must be accepted):
[47653726-2c14-4441-83f6-11f8cf91073f]   
[47653726-2c14-4441-83f6-11f8cf91073f] app/models/concerns/omniauthable.rb:49:in `create_for_oauth'
[47653726-2c14-4441-83f6-11f8cf91073f] app/models/concerns/omniauthable.rb:30:in `find_for_oauth'
[47653726-2c14-4441-83f6-11f8cf91073f] app/controllers/auth/omniauth_callbacks_controller.rb:10:in `block in provides_callback_for'
@moritzheiber
Copy link
Member

This is the breaking PR: #9572

@moritzheiber
Copy link
Member

cc @Gargron as the original PR author, @nolanlawson @mayaeh as reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants