Add polls #10111

Gargron · 2019-02-25T03:45:27Z

TODO:

TODO in separate PRs:

Web UI component for creating polls

tateisu · 2019-02-25T04:01:02Z

How do we see this from the ActivityPub?

There is a version of friends.nico as an existing implementation.
In the case of friends.nico, voting has time limit. The result was output as another post.

Gargron · 2019-02-25T04:49:27Z

How do we see this from the ActivityPub?

In my understanding, when a poll is attached to a status, the status should have type Question instead of Note, and contain oneOf/anyOf/closed properties. I do not know yet how exactly the vote counts would be represented. Perhaps the items inside oneOf/anyOf would have a replies property containing a Collection with totalItems...

In the case of friends.nico, voting has time limit.

Represented here by expires_at property (optional). Although perhaps it should not be optional, who ever needs infinite polls?

app/serializers/activitypub/note_serializer.rb

Fix #1629

ClearlyClaire

Overall, I like this PR, but I have some concerns. Mainly, we make a few arbitrary choices that may not work well with other implementations:

as far as I can see, we don't allow for changing votes, that is, neither deleting existing votes, nor overwriting existing ones. If other implementations allow this, we don't have a correct error path to notify them that their vote is invalid. This may lead to inconsistent user experience.
polls and media being mutually exclusive kind of makes sense with the current UI, but other software might have different interfaces and not have that limit
the number of replies etc. are quite arbitrary and might also be an issue

An interesting thing is that polls being tied to a Note, they are only visible to the audience of that Note. However, the voting code does not seem to enforce that only the audience can vote. It might be worth tightening those restrictions.

Finally, we could send and support Update of the poll/its collections to update the tallies without the need for fetching changes.

app/controllers/api/v1/statuses_controller.rb

app/lib/activitypub/activity/create.rb

app/models/poll.rb

app/serializers/activitypub/note_serializer.rb

app/serializers/activitypub/vote_serializer.rb

ClearlyClaire · 2019-03-03T11:31:14Z

app/services/activitypub/fetch_remote_poll_service.rb

+    poll.update!(
+      expires_at: expires_at,
+      cached_tallies: items.map { |item| item.dig('replies', 'totalItems') || 0 }
+    )


Same remark as earlier, what about fetching collections that aren't inlined?
Furthermore, if the poll has changed since it was initially fetched, this code will produce inconsistent tallies.

Furthermore, if the poll has changed since it was initially fetched, this code will produce inconsistent tallies.

I don't understand what you mean. This is fetched from the origin, for remote polls. The origin has the most correct count of votes.

Sorry, I meant that if the list of options changed (which nothing in the specs forbids), the updated tallies are going to be garbage.

I don't think updating the options of published polls should be allowed. That invalidates the results.

You could reorder them or add requested options, I don't know. I think we should at least update tallies based on name, not on the option's position in the serialization.

app/validators/poll_validator.rb

ClearlyClaire · 2019-03-03T18:02:35Z

I'm also thinking that, in the case we can't manage getting tallies from the remote server (because there is nothing standardized for that and the suggested solution is the Question's replies thing, which we do not want), we should offer to go to the remote public page to see the results.

Also, aren't we missing code to display the poll on public pages?

ClearlyClaire · 2019-03-03T20:32:52Z

app/models/status.rb

@@ -250,6 +255,8 @@ def decrement_count!(key)
  before_validation :set_conversation
  before_validation :set_local

+  before_save :set_poll_id


We can use a normal association instead of this, now, can't we?

We have this throwaway inverse reference to polls so that during eager-loading we can skip queries on the polls table when no statuses have polls, which I believe would be the most common case.

ClearlyClaire · 2019-03-03T20:33:10Z

db/migrate/20190226003449_add_poll_id_to_statuses.rb

@@ -0,0 +1,5 @@
+class AddPollIdToStatuses < ActiveRecord::Migration[5.2]
+  def change
+    add_column :statuses, :poll_id, :bigint


Same goes here, we can use a foreign key.

I think foreign keys are an increasingly bad idea. It requires having an index on that column, otherwise DELETE or NULLIFY cascades take an incredible amount of time. Any index on statuses would also be massive.

ClearlyClaire

I think poll_vote? is still very confusing, fallback for remote implementations not using our replies scheme should be considered, limits could be tweaked, and we could investigate sending Updates and fetching the size of replies collections identified by an URI instead of being inlined, but that's all stuff that can be done later.

mattcoxonline · 2019-03-04T21:00:53Z

Do you have a design for the creation of polls in the web UI, @Gargron ? Want me to create some mocks?

Gargron · 2019-03-05T01:01:04Z

@mattcoxonline I do not have a design. You can give it a go...

* Add polls Fix mastodon#1629 * Add tests * Fixes * Change API for creating polls * Use name instead of content for votes * Remove poll validation for remote polls * Add polls to public pages * When updating the poll, update options just in case they were changed * Fix public pages showing both poll and other media

Gargron added work in progress Not to be merged, currently being worked on api REST API, Streaming API, Web Push API activitypub Protocol-related changes, federation labels Feb 25, 2019

Gargron force-pushed the feature-polls branch from 863eb2a to 6e74d83 Compare February 25, 2019 03:51

acid-chicken mentioned this pull request Feb 25, 2019

リモートで投票を見たりしたりできるように misskey-dev/misskey#3940

Merged

Gargron force-pushed the feature-polls branch 6 times, most recently from 8e99cfb to b0d0db6 Compare February 26, 2019 03:00

ClearlyClaire reviewed Feb 26, 2019

View reviewed changes

app/serializers/activitypub/note_serializer.rb Show resolved Hide resolved

ClearlyClaire reviewed Feb 26, 2019

View reviewed changes

app/serializers/activitypub/note_serializer.rb Outdated Show resolved Hide resolved

Gargron force-pushed the feature-polls branch from b0d0db6 to c24b774 Compare February 26, 2019 16:28

ClearlyClaire reviewed Feb 26, 2019

View reviewed changes

app/serializers/activitypub/note_serializer.rb Show resolved Hide resolved

Gargron force-pushed the feature-polls branch 13 times, most recently from a7d0e9f to 63a1a44 Compare March 2, 2019 23:13

Gargron force-pushed the feature-polls branch 5 times, most recently from 16ac9ae to 4ffe700 Compare March 3, 2019 02:35

Gargron removed the work in progress Not to be merged, currently being worked on label Mar 3, 2019

Gargron marked this pull request as ready for review March 3, 2019 02:35

Add polls

d7a3502

Fix #1629

Gargron force-pushed the feature-polls branch from 4ffe700 to d7a3502 Compare March 3, 2019 02:37

ClearlyClaire reviewed Mar 3, 2019

View reviewed changes

Add tests

cbc7f32

acid-chicken mentioned this pull request Mar 3, 2019

Update poll federation misskey-dev/misskey#4407

Closed

Fixes

248dbea

Gargron added 6 commits March 3, 2019 20:29

Change API for creating polls

657fe25

Use name instead of content for votes

ed89e50

Remove poll validation for remote polls

ac897cb

Add polls to public pages

9ab603f

When updating the poll, update options just in case they were changed

6e7ff52

Fix public pages showing both poll and other media

6f68d63

ClearlyClaire reviewed Mar 3, 2019

View reviewed changes

ClearlyClaire approved these changes Mar 3, 2019

View reviewed changes

Gargron merged commit 230a012 into master Mar 3, 2019

Gargron deleted the feature-polls branch March 3, 2019 21:18

connyduck mentioned this pull request Mar 4, 2019

Add support for polls tuskyapp/Tusky#1102

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add polls #10111

Add polls #10111

Gargron commented Feb 25, 2019 •

edited

Loading

tateisu commented Feb 25, 2019

Gargron commented Feb 25, 2019

ClearlyClaire left a comment

ClearlyClaire Mar 3, 2019

Gargron Mar 3, 2019

ClearlyClaire Mar 3, 2019 •

edited

Loading

Gargron Mar 3, 2019

ClearlyClaire Mar 3, 2019

ClearlyClaire commented Mar 3, 2019

ClearlyClaire Mar 3, 2019

Gargron Mar 3, 2019

ClearlyClaire Mar 3, 2019

Gargron Mar 3, 2019

ClearlyClaire left a comment

mattcoxonline commented Mar 4, 2019

Gargron commented Mar 5, 2019

Add polls #10111

Add polls #10111

Conversation

Gargron commented Feb 25, 2019 • edited Loading

tateisu commented Feb 25, 2019

Gargron commented Feb 25, 2019

ClearlyClaire left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClearlyClaire Mar 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClearlyClaire commented Mar 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClearlyClaire left a comment

Choose a reason for hiding this comment

mattcoxonline commented Mar 4, 2019

Gargron commented Mar 5, 2019

Gargron commented Feb 25, 2019 •

edited

Loading

ClearlyClaire Mar 3, 2019 •

edited

Loading