Fix various issues in polls #10165
Merged
Fix various issues in polls #10165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gargron
commented
Mar 4, 2019
Gargron
commented
- Fix ActivityPub serializer exposing vote counts on hide_totals polls before expiration
- Fix refresh button on polls having smaller font-size
- Fix OpenGraph description missing poll text
Regression from #10158
- Fix NoMethodError when serializing votes - Fix public pages with polls for non-logged-in users - Fix display of remaining time when poll has no expiration date
nightpool
approved these changes
Mar 5, 2019
ykzts
approved these changes
Mar 5, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Fix ActivityPub poll results being serialized even with hide_totals * Fix poll refresh button having a different font size * Display poll in OpenGraph description * Fix NoMethodError when serializing votes Regression from mastodon#10158 * Fix polls on public pages being broken for non-logged-in users * Do not show time remaining if poll has no expiration date
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* Fix ActivityPub poll results being serialized even with hide_totals * Fix poll refresh button having a different font size * Display poll in OpenGraph description * Fix NoMethodError when serializing votes Regression from mastodon#10158 * Fix polls on public pages being broken for non-logged-in users * Do not show time remaining if poll has no expiration date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.