Refactor all ActivityPub deliveries to be serialized and signed through one concern #10966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
refactor-serialize-payload
branch
4 times, most recently
from
df89093
to
46dad7b
Compare
Gargron
force-pushed
the
refactor-serialize-payload
branch
from
46dad7b
to
8a7640c
Compare
ClearlyClaire
approved these changes
Jun 4, 2019
| sign_with = options.delete(:sign_with) | ||
| payload = ActiveModelSerializers::SerializableResource.new(record, options.merge(serializer: serializer, adapter: ActivityPub::Adapter)).as_json | ||
|
|
||
| if (record.respond_to?(:sign?) && record.sign?) && signer && signing_enabled? |
There was a problem hiding this comment.
small nitpick, those parenthesis do not help with readability
| @@ -0,0 +1,19 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module Payloadable | |||
There was a problem hiding this comment.
Small nitpick: this name is weird, especially since it's used by services and not models…
I believe AMS was configured to use Oj in the background so there is no difference, except that the output of |
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Jan 7, 2021
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.