-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeline read markers API #11762
Conversation
d625f50
to
34d7282
Compare
34d7282
to
5d983b2
Compare
I have a few questions about this implementation:
/cc @charlag |
I agree with @nolanlawson on the first one.
|
Well, what if you have multiple clients open? And they all try to update the position at the same time? If they all use the streaming API I suppose they would arrive at similar or identical results but it seems wasteful to just keep updating it back and forth between them all. I'm not sure what the point would be of saving and loading a marker while a client is already actively open, the other app would then load the top of the timeline anyway..? |
It could be done in the way that we send it to the server and server writes it only when the client stops communicating but that's complicated I guess. Edit: a lot of spelling |
Fix #4093, fix #7418, close #6756
GET /api/v1/markers
timeline
array param. Response is a map with timeline names as keysPOST /api/v1/markers
last_read_id
by submitting a map with timeline names as keys. The keys can behome
ornotifications
JSON returned includes
last_read_id
,updated_at
andversion
(which increments on every update).