Fix search error when ElasticSearch is enabled but not available #11954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
requested changes
Sep 25, 2019
Gargron
reviewed
Sep 26, 2019
| from_database | ||
| end | ||
| results = from_elasticsearch if Chewy.enabled? | ||
| results = from_database if results.nil? |
There was a problem hiding this comment.
OK, just write it like results ||= from_database
Gargron
approved these changes
Sep 26, 2019
Gargron
changed the title
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…todon#11954) * Fallback to Database search when ES not available * Prevent double work if ES gives 0 result * Apply suggestion from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #9654, It fallback to database search when ES is not available.