Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SQL query when performing account search amongst followings #12302

Merged

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

Copy link
Member

@Gargron Gargron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t this going to search only among one’s own followers, rather than followed people?

@ClearlyClaire
Copy link
Contributor Author

I don't think so? The left outer join is just to compute the score: it's here in the query not restricted to followers too, and its goal is to bump the score along follow relationships. But when searching people you follow, all of them are by definition followed by you, so it's not useful to match those follow relations, they'd bump the score the same way for every account.

@Gargron Gargron merged commit 2edf6d8 into mastodon:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants