Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP & PAM added to OAuth password grant strategy #12390

Merged
merged 1 commit into from Nov 30, 2019

Commits on Nov 25, 2019

  1. LDAP & PAM added to OAuth password grant strategy (mastodon#7999)

    When authenticating via OAuth, the resource owner password grant
    strategy is allowed by Mastodon, but (without this PR), it does not
    attempt to authenticate against LDAP or PAM. As a result, LDAP or PAM
    authenticated users cannot sign in to Mastodon with their
    email/password credentials via OAuth (for instance, for native/mobile
    app users).
    
    This PR fleshes out the authentication strategy supplied to doorkeeper
    in its initializer by looking up the user with LDAP and/or PAM when
    devise is configured to use LDAP/PAM backends. It attempts to follow the
    same logic as the Auth::SessionsController for handling email/password
    credentials.
    
    Note mastodon#1: Since this pull request affects an initializer, it's unclear
    how to add test automation.
    
    Note mastodon#2: The PAM authentication path has not been manually tested. It
    was added for completeness sake, and it is hoped that it can be manually
    tested before merging.
    ntl-purism committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    dfb3492 View commit details
    Browse the repository at this point in the history