Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return discoverable via REST API (fix #12507) #12508

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Return discoverable via REST API (fix #12507) #12508

merged 1 commit into from
Dec 3, 2019

Conversation

trwnh
Copy link
Member

@trwnh trwnh commented Dec 1, 2019

I think this should fix it?

https://github.com/tootsuite/mastodon/blob/master/app/serializers/rest/credential_account_serializer.rb is another place that it could be returned instead, but I think in the long-term it is valuable to know whether an account is discoverable even if it is not your own account.

@Gargron
Copy link
Member

Gargron commented Dec 1, 2019

Maybe this also resolves #7822?

@trwnh
Copy link
Member Author

trwnh commented Dec 1, 2019

I would be fine if we said toot:discoverable was also intended as an indexing flag, yes

@ClearlyClaire
Copy link
Contributor

As you said in your last comment on that PR, those seem to be different concerns…

@Gargron
Copy link
Member

Gargron commented Dec 1, 2019

Discoverable is a better indicator though because it federates. The noindex setting is local-only so it would never be correct for remote accounts in the API. Its use case is also so narrow that it's not worth federating, while "discoverable" could be used for multiple things that stem from one desire to be discovered or to not be discovered.

@trwnh
Copy link
Member Author

trwnh commented Dec 1, 2019

if you consider the profile directory as a sort of index, then opting out of indexing would imply opting out of the directory, and vice versa would be similar enough to the point that maybe two different properties aren't needed.

@Gargron Gargron merged commit 4354936 into mastodon:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants