Change mastodon:setup to not call assets:precompile in docker #13942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jun 8, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@ThibG bump |
|
This could be done unconditionally if #14381 gets merged |
It appears assets are built during image build, and they shouldn't need to be rebuilt, since we now have reproducible builds.
ClearlyClaire
force-pushed
the
fixes/docker-mastodon-setup-assets-precompile
branch
from
890d348
to
3c3ae53
Compare
|
Rebased and changed it so that it applies even if S3 is enabled, as we now have reproducible builds regardless of S3/CDN config. |
ClearlyClaire
changed the title
Gargron
approved these changes
Mar 24, 2021
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
…on#13942) It appears assets are built during image build, and they shouldn't need to be rebuilt, since we now have reproducible builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iy appears assets are built during image build, and they shouldn't need
to be rebuilt unless using S3, in which case it needs to be recompiled to
include the configured host.
(I'm not completely sure of all that, someone with more knowledge than me on the Docker setup should check)