Fix unpermitted operations on custom emojis leading to cryptic errors #13951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
requested changes
Jun 3, 2020
ClearlyClaire
force-pushed
the
fixes/delete-custom-emoji
branch
from
345eb7c
to
afd7cd9
Compare
ClearlyClaire
force-pushed
the
fixes/delete-custom-emoji
branch
from
afd7cd9
to
723f991
Compare
ClearlyClaire
force-pushed
the
fixes/delete-custom-emoji
branch
from
723f991
to
883c554
Compare
Gargron
approved these changes
Jun 5, 2020
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
…mastodon#13951) * Display appropriate error when performing unpermitted operation on custom emoji Fixes mastodon#13897 * Remove links to custom emoji actions not performable by moderators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13897
Also remove links to perform the unpermitted actions altogether.
An alternative would be to just allow moderators to handle custom emoji.