Toolbar icons accessible names #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes mastodon#1349 This is my first PR and I’m only checking in the source JSX file. Please let me know if it should be checked in after being built also.
ashfurrow
approved these changes
Apr 21, 2017
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 26, 2017
Closes mastodon#1349 This is my first PR and I’m only checking in the source JSX file. Please let me know if it should be checked in after being built also.
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 28, 2017
Closes mastodon#1349 This is my first PR and I’m only checking in the source JSX file. Please let me know if it should be checked in after being built also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1349 by
aria-labelto<i>iconsrole="img"to<i>iconsThis is my first PR and I’m only checking in the source JSX file.
Please let me know if it should be checked in after being built also.
The Issue
Toolbar icons are not accessible to assistive tech.
GIF
The solution
Toolbar icons are accessible to assistive tech.
GIF
See Also