Fix boosted toots from blocked account not being retroactively removed from TL #14339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Jul 17, 2020
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
…d from TL (mastodon#14339) * Fix boosted toots from blocked account not being retroactively removed from TL Fixes mastodon#14301 * Add test for clear_from_timeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14301
Upon blocking someone, some cleanup code is called to remove content from the home timeline. Currently, this only removes toots directly posted by the blocked person, not boosts of such toots, nor toots mentioning them, which is inconsistent with how blocks filter toots.
This PR attempts to do so in a relatively efficient fashion. It should do up to 3 simple SQL queries leveraging indexes:
reblog_of_idandaccount_idof all toots in the home TL (max 400 items, query matching an index)