-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor how public and tag timelines are queried #14728
Conversation
ab8cdf0
to
175232c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I agree with the “Don't allow any/all/none filters in RSS and JSON-LD versions of the public hashtag resource” part, but otherwise it seems fine to me.
Minor remarks in inline comments.
Also, HashtagQueryService
doesn't seem to be used anymore, but the PR doesn't remove its definition.
175232c
to
eb0fbfc
Compare
Even if you discard that joining multiple tags is a more expensive operation, I don't think it's right for a JSON-LD resource to represent a complex union of different collections... It should be 1:1, in my opinion. Also nobody knows this feature even exists. |
Contains some minor behaviour changes: