Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how public and tag timelines are queried #14728

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Sep 4, 2020

Contains some minor behaviour changes:

  • Excluded suspended accounts from public timelines (was not enforced previously)
  • No longer show silenced user own posts in public timelines (silenced users can no longer make public posts anyway)
  • Don't allow any/all/none filters in RSS and JSON-LD versions of the public hashtag resource
  • Make JSON-LD version of public hashtag resource support min_id/since_id (consistently with outbox)

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with the “Don't allow any/all/none filters in RSS and JSON-LD versions of the public hashtag resource” part, but otherwise it seems fine to me.

Minor remarks in inline comments.

Also, HashtagQueryService doesn't seem to be used anymore, but the PR doesn't remove its definition.

spec/models/public_feed_spec.rb Outdated Show resolved Hide resolved
spec/models/public_feed_spec.rb Outdated Show resolved Hide resolved
spec/models/public_feed_spec.rb Outdated Show resolved Hide resolved
app/models/public_feed.rb Show resolved Hide resolved
app/models/tag_feed.rb Show resolved Hide resolved
@Gargron
Copy link
Member Author

Gargron commented Sep 6, 2020

I'm not sure I agree with the “Don't allow any/all/none filters in RSS and JSON-LD versions of the public hashtag resource” part

Even if you discard that joining multiple tags is a more expensive operation, I don't think it's right for a JSON-LD resource to represent a complex union of different collections... It should be 1:1, in my opinion. Also nobody knows this feature even exists.

@Gargron Gargron merged commit e8bc187 into master Sep 7, 2020
@ykzts ykzts deleted the refactor-public-timelines branch September 7, 2020 10:08
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 7, 2020
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants