Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruby 2.7.2 #15150

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Use Ruby 2.7.2 #15150

merged 1 commit into from
Nov 19, 2020

Conversation

zunda
Copy link
Contributor

@zunda zunda commented Nov 13, 2020

thwait and e2mmap are no longer needed in Gemfile. Gems properly require those.

thwait and e2mmap are no longer needed in Gemfile.
Gems properly require those.
@ClearlyClaire
Copy link
Contributor

I am not against that, and I actually use Ruby 2.7.2 as provided by my distribution, but some of our dependencies are still using deprecated language constructs, resulting in pretty polluted logs.

@nightpool
Copy link
Member

Ruby 2.7 has incompatibilities in keyword arguments also, right? So there could be a bug introduced because of the change in how keyword arguments is handled between versions

@zunda
Copy link
Contributor Author

zunda commented Nov 13, 2020

Thanks for comments!

Deprecation warnings are turned off by default on 2.7.2 so logs should be cleaner than 2.7.0 and 2.7.1. Running rspec, the code generated warnings at only two lines:

$ bundle exec rspec 2>/tmp/warnings.txt
  :
3026 examples, 0 failures, 23 pending

Randomized with seed 40915
Coverage report generated for RSpec to .../mastodon/coverage. 13789 / 20177 LOC (68.34%) covered.
$ sort -u /tmp/warnings.txt
.../vendor/bundle/ruby/2.7.0/gems/cld3-3.3.0/lib/cld3.rb:91: warning: rb_safe_level will be removed in Ruby 3.0
.../vendor/bundle/ruby/2.7.0/gems/rotp-2.1.2/lib/rotp/totp.rb:56: warning: URI.escape is obsolete

I'd say the Mastodon code is pretty compatible with ruby-2.7.2. rspec completes successfully. My server has been on ruby-2.7.2 since October 2nd. I haven't seen any problem due to the ruby version, but yeah there are features I have never used on my single user server.

@shleeable
Copy link
Contributor

shleeable commented Nov 14, 2020

rotp 2.1.2 is from april 2016.. there is a version 6.2.0 from a few months ago https://rubygems.org/gems/rotp/versions

@shleeable
Copy link
Contributor

shleeable commented Nov 14, 2020

image

Working without issue with this PR for the last few hours.... we'll come back tomorrow

@shleeable
Copy link
Contributor

LGTM. Tested without issue so far. Merge away.

@Gargron Gargron merged commit 541b9f8 into mastodon:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants