ignore hashtag suggestions if they vary only in case

[weex]

Fixes #16449 by adding an ignoreSuggestion event.

[ClearlyClaire]

I wonder if, instead of adding an event type, it wouldn't be better to change insertSuggestion so that it selects either the completion or token based on the case-insensitive comparison.

I also wonder if it wouldn't make sense, if the two strings differ in casing only, and one is lowercase-only, to select the other, as it is most likely more readable.

[weex]

I wonder if, instead of adding an event type, it wouldn't be better to change insertSuggestion so that it selects either the completion or token based on the case-insensitive comparison.

The issue there is that the token is already lowered when populating textAtCursorMatchesToken (https://github.com/tootsuite/mastodon/blob/main/app/javascript/mastodon/components/autosuggest_textarea.js#L11) so either we need to pass through another argument or return the non-lowered token there.

I also wonder if it wouldn't make sense, if the two strings differ in casing only, and one is lowercase-only, to select the other, as it is most likely more readable.

It might but it's probably better in another PR.

[ClearlyClaire]

I wonder if, instead of adding an event type, it wouldn't be better to change insertSuggestion so that it selects either the completion or token based on the case-insensitive comparison.

The issue there is that the token is already lowered when populating textAtCursorMatchesToken (https://github.com/tootsuite/mastodon/blob/main/app/javascript/mastodon/components/autosuggest_textarea.js#L11) so either we need to pass through another argument or return the non-lowered token there.

Ah, I missed the token being lowercased already. It's a bit convoluted, but the initial text can easily be recovered by doing something like map.get(path).slice(position, position + token.length).

I also wonder if it wouldn't make sense, if the two strings differ in casing only, and one is lowercase-only, to select the other, as it is most likely more readable.

It might but it's probably better in another PR.

I agree, to a point, but I'd like to also avoid multiple successive behavior changes if possible.

[rkingett]

This is a welcomed proposed change.

[weex]

Thanks @ClearlyClaire, I updated with your proposed change which cleared the inconsistency about the space.

This PR isn't perfect but it's progress so leaving this issue for now. The comments above about map.get(path).slice(position, position + token.length) might be a better way to solve if anyone else wants to tackle.

[ClearlyClaire]

I still prefer my earlier suggestion, but this PR looks good to me and is an improvement upon the current behavior.

[ClearlyClaire]

Was this closed by error?

[weex]

Yes

[FediVideos]

Is there some reason this was closed?

[weex]

Thanks for the ping. This was created when the magicstone-dev repo was my personal one and since then I've been trying to delete any branches other than main due to 2.5.1 here. So as you see from the history I've deleted and recreated the branch a couple of times, while reopening the PR is less obvious a step after that.

[weex]

Can't tell what the problem was in CI since I suppose the logs have been deleted after a few months in DeepSource. If this gets re-run, please ping me to let me know if anything needs to be done.

[ClearlyClaire]

It likely was an issue with DeepSource itself, and not your code (sometimes, it would basically re-check everything, not only the changed parts). I'd rebase and force-push.

[FediVideos]

Has this change been implemented in the latest version of Masto? At the moment I get the following results:

On Mastodon.online (v3.4.6): Try to type #HashTag but suggestions turn it into #häshtäg (with umlauts!)

On Mas.to (v3.4.6): Try to type #HashTag but suggestions turn it into #hashtag

On Mstdn.social (v3.4.6+glitch): Try to type #HashTag, successfully stays as #HashTag

[ClearlyClaire]

Mastodon.online and Mstdn.social would have that change, not Mas.to as far as I know. The umlauts thing is interesting :D

[FediVideos]

So, it is there but broken on mastodon.online? Just tried it again and it still does that umlaut thing...

Is there a correct procedure for asking this to be fixed? (Sorry, I'm not that familiar with how github works!)

[rkingett]

Just checked on my instance, writing exchange, and it is still changing it to all lower case. I wish the opposite would happen, where all hashtags were changed to CammelCase. In order for this to work, this PR must be merged into the main branch, which it looks like it has?

[weex]

Tried it on fosstodon (v.3.4.6_ and it seems to be working as expected. @FediVideos the best place is probably to create a new issue. Could be a subtle way in how you're using it? Timing of hitting tab vs. enter vs. space. In a new issue you could describe exactly what you're doing and mention this issue number so there's a trail for later peeps to follow.

[ClearlyClaire]

Note that this has not landed in any release, it's only in the development version (which is currently also reported as 3.4.6).

[FediVideos]

Weird, it is now working perfectly on mastodon.online!

I am typing HashTag, the top suggestion is hashtag but pressing enter or space leaves me with HashTag (which is exactly how it should behave!). Still have no idea what caused the umlaut thing or why the issue went away.

So, when is this expected to roll out to release versions?