Fix owned account notes not being deleted when an account is deleted #16579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/account-notes-on-account-deletion
branch
from
be29b5e
to
21c89b0
Compare
Gargron
approved these changes
Aug 8, 2021
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 10, 2022
…astodon#16579) * Add account_notes relationship * Add tests * Fix owned account notes not being deleted when an account is deleted * Add post-migration to clean up orphaned account notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account is deleted while keeping its
accountrecord (which is the default when definitely suspending, or self-deleting a local account), account notes owned by this account are not deleted, unlike any other data owned by the deleted account.In addition to keeping private data for longer than it should (possibly indefinitely), this also may be the root cause for the issue addressed in #16576.
This PR fixes
DeleteAccountServiceto delete those account notes, and adds a migration script to automatically delete every already-orphaned account notes.