Remove delete & redraft #16766
Closed
Remove delete & redraft #16766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
added
api
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| }; | ||
|
|
||
| export function deleteStatus(id, routerHistory, withRedraft = false) { | ||
| export function deleteStatus(id, routerHistory) { |
There was a problem hiding this comment.
'routerHistory' is defined but never used.
|
I think you may be rushing things out quite a bit ^^' |
|
Minor point of consideration: "delete & redraft" allows changing privacy level. While editing posts will be immensely useful, it doesn't cover the use case of previewing a post first, a feature Mastodon does not (yet?) implement. Posting something as a DM to nobody allows for testing embeds, links, etc, with "delete & redraft" enabling re-posting as Public/etc when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #16697
Breaking changes:
textproperty with source textObviously, we'll probably need to wait a period during which these API behaviours will be deprecated before they are removed.