Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on trending hashtags/links pages in admin UI due to missing constant #17044

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Nov 25, 2021

@Gargron Gargron added the bug Something isn't working label Nov 25, 2021
@ClearlyClaire
Copy link
Contributor

#17043 😩

Moving this to a decaying? method makes sense though.

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I would have done entirely without the overcomplicated options thing (as in #17043). Moving the test to a decaying? method is a good thing though.

@Gargron Gargron merged commit 12b3ff6 into main Nov 26, 2021
@Gargron Gargron deleted the fix-trends-const branch November 26, 2021 00:13
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants