Fix follow recommendation biased towards older accounts #17126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+24
| class UpdateAccountSummariesToVersion2 < ActiveRecord::Migration[6.1] | ||
| def up | ||
| reapplication_follow_recommendations_v2 do | ||
| drop_view :account_summaries, materialized: true | ||
| create_view :account_summaries, version: 2, materialized: { no_data: true } | ||
| safety_assured { add_index :account_summaries, :account_id, unique: true } | ||
| end | ||
| end | ||
|
|
||
| def down | ||
| reapplication_follow_recommendations_v2 do | ||
| drop_view :account_summaries, materialized: true | ||
| create_view :account_summaries, version: 1, materialized: { no_data: true } | ||
| safety_assured { add_index :account_summaries, :account_id, unique: true } | ||
| end | ||
| end | ||
|
|
||
| def reapplication_follow_recommendations_v2 | ||
| drop_view :follow_recommendations, materialized: true | ||
| yield | ||
| create_view :follow_recommendations, version: 2, materialized: { no_data: true } | ||
| safety_assured { add_index :follow_recommendations, :account_id, unique: true } | ||
| end | ||
| end |
There was a problem hiding this comment.
I wonder if, instead of the reapplication_follow_recommendations_v2 thing, you can use replace_view instead? Since the columns are exactly the same in the same order, I think this should work.
There was a problem hiding this comment.
Actually, no this is not possible. This is only possible for non-materialized views.
There was a problem hiding this comment.
I'm looking forward to scenic's update_view reducing this verbose description, but not yet.
scenic-views/scenic#218
Gargron
approved these changes
Dec 13, 2021
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the follow recommendations do not show the newly recognized accounts by the server, as the wrong refinement will preferentially select the old account ID. Fix this.
Also, since the boost is included when detecting the language used by the account from the status, the language detection fails in rare cases. Fix this.