Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign in token and warning emails failed to send in some cases #17589

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Fix sign in token and warning emails failed to send in some cases #17589

merged 1 commit into from
Feb 18, 2022

Conversation

helloworldstack
Copy link
Contributor

When Setting.site_contact_email was incorrectly set with an invalid value such as - it could cause sign in token email failed to send with some SMTP providers such as Amazon SES because of invalid Reply-To. This also affect warning email on the same app/mailers/user_mailer.rb file.

Example error in Sidekiq Jobs

UserMailer#sign_in_token
Net::SMTPFatalError: 554 Transaction failed: Missing final '@domain'

Generally Setting.site_contact_email value should not have any effects on the ability to send sign in token or warning emails (UserMailer.sign_in_token and UserMailer.warning functions). Therefore reply_to field should use the global SMTP_REPLY_TO variable (#11718) instead based on config/environments/production.rb.

@Gargron Gargron merged commit 2426577 into mastodon:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants