Fix sign in token and warning emails failed to send in some cases #17589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Setting.site_contact_email
was incorrectly set with an invalid value such as-
it could cause sign in token email failed to send with some SMTP providers such as Amazon SES because of invalidReply-To
. This also affect warning email on the sameapp/mailers/user_mailer.rb
file.Example error in Sidekiq Jobs
Generally
Setting.site_contact_email
value should not have any effects on the ability to send sign in token or warning emails (UserMailer.sign_in_token
andUserMailer.warning
functions). Thereforereply_to
field should use the globalSMTP_REPLY_TO
variable (#11718) instead based onconfig/environments/production.rb
.