Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data integrity of featured tags #17712

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 7, 2022

I am not sure why this was not enforced before. There is no use case I can think of where a featured tag should have no account or no tag it belongs to.

@Gargron Gargron force-pushed the fix-featured-tags-integrity branch from f5e2103 to 9a192d8 Compare March 9, 2022 05:44
@Gargron Gargron marked this pull request as ready for review March 9, 2022 05:45
@Gargron Gargron added the bug Something isn't working label Mar 9, 2022
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't hurt, but were there any case where this did happen?

@Gargron
Copy link
Member Author

Gargron commented Mar 9, 2022

Yes, sometimes I get errors in my log rendering someone's profile page who has a featured tag without a tag.

I am not sure how it came about, though.

@Gargron Gargron merged commit 318d34d into main Mar 9, 2022
@Gargron Gargron deleted the fix-featured-tags-integrity branch March 9, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants