Give SINGLE_USER a chance to register

[saper]

An attempt to open a brand new Mastodon instance configured
as SINGLE_USER_MODE=true will cause an exception.

Enable temporary registration if we have no users in the database

Fixes #1817

[saper]

Looks like controller helper_method is a trick that the test suite does not like, will have a look at it

[mjankowski]

Instead of doing this check on every request, could we improve the docs to make it more clear that single user instances need to create accounts prior to being able to use the app?

[Gargron]

I suggest renaming this to single_user_mode?

[saper]

It was that in my first draft :) thanks

[Gargron]

And this could be @single_user_mode ||= Rails.configuration.x.single_user_mode && Account.first for multiple calls

[Gargron]

Didn't mean to click approve, meant to click reqest changes

[saper]

I was thinking about spitting out the error message instead.

Is the Account.first check expensive? If yes, then we could store the result somewhere?

[Gargron]

@mjankowski The DB check only occurs when single user mode is enabled, and it would occur anyway for the redirect to the right profile, so I think that's not a big deal

[saper]

Wow, thanks.

I've tried to fix the tests by doing

diff --git a/spec/views/accounts/show.html.haml_spec.rb b/spec/views/accounts/show.html.haml_spec.rb
index 8265b2f4..1fc75da7 100644
--- a/spec/views/accounts/show.html.haml_spec.rb
+++ b/spec/views/accounts/show.html.haml_spec.rb
@@ -10,6 +10,8 @@ describe "stream_entries/show.html.haml" do
   end
 
   it "has valid author h-card and basic data for a detailed_status" do
+    allow(view).to receive(:single_user_mode?).and_return(false)
+
     alice  =  Fabricate(:account, username: 'alice', display_name: 'Alice')
     bob    =  Fabricate(:account, username: 'bob', display_name: 'Bob')
     status =  Fabricate(:status, account: alice, text: 'Hello World')
@@ -32,6 +34,8 @@ describe "stream_entries/show.html.haml" do
   end
 
   it "has valid h-cites for p-in-reply-to and p-comment" do
+    allow(view).to receive(:single_user_mode?).and_return(false)
+
     alice   =  Fabricate(:account, username: 'alice', display_name: 'Alice')
     bob     =  Fabricate(:account, username: 'bob', display_name: 'Bob')
     carl    =  Fabricate(:account, username: 'carl', display_name: 'Carl')

but causes the <someverylangeclassdescription does not implement: single_user_mode? which looks like lack of the controller spec or rspec/rspec-rails#1076 to me

[Gargron]

@saper Right, I am still encountering the test issue. Really annoying. Any solution?

[Gargron]

Never mind, found a hacky way to fix those tests.

[saper]

Nice.

What would be the proper way ? Providing spec for application controller?