Fix broken dependencies in helm chart and allow using existing secrets in the chart #18941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepy
changed the title
|
This has been tested with an external database |
|
Updated to postgresql 11 and tested fine with inline secrets in values.yaml |
|
and now SMTP password can also be put in a secret. |
This to allow setting LOGIN either in values.yaml or in the secret.
|
@dunn given your involvement in the issue, would you be able to have a look at this PR? |
dunn
approved these changes
Aug 8, 2022
This prevents older versions from disappearing, see bitnami/charts#10539 for full context.
|
@dunn thanks for having a look at this! :-) |
|
@deepy oh right! thanks for picking that up |
Gargron
approved these changes
Aug 10, 2022
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
…s in the chart (mastodon#18941) * Add ability to specify an existing Secret (mastodon#18139) Closes mastodon#18139 * Allow using secrets with external postgres * Upgrade CronJob to batch/v1 * Allow using redis.auth.existingSecret * Helmignore mastodon-*.tgz for easy local development * Upgrade helm dependencies * Upgrade postgresql to 11 * Allow putting SMTP password into a secret * Add optional login to SMTP secret This to allow setting LOGIN either in values.yaml or in the secret. * Switch to bitnami charts full archive This prevents older versions from disappearing, see bitnami/charts#10539 for full context. Co-authored-by: Ted Tramonte <ted.tramonte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the work from @tedtramonte in #18179 and updates the chart dependencies to the lowest version still available.
The chart in mastodon/mastodon on main currently does not work as it depends on chart versions that no longer exist, this fixes that while also adding the ability to put the SMTP password into a secret.
Additionally this closes #18139