Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor code style issues #19020

Closed
wants to merge 3 commits into from
Closed

Fix minor code style issues #19020

wants to merge 3 commits into from

Conversation

shleeable
Copy link
Contributor

@shleeable shleeable commented Aug 21, 2022

No idea why the linter is angry at me.

@shleeable shleeable changed the title Minor tweaks [Minor] Tweaks Aug 22, 2022
@ClearlyClaire ClearlyClaire changed the title [Minor] Tweaks Fix minor code style issues Aug 23, 2022
@ClearlyClaire
Copy link
Contributor

No idea why the linter is angry at me.

The linter isn't angry at you but at other lines of the files you changed. It's an unfortunate behavior of the new lint action…

Otherwise, those changes look fine to me, but please use more informative PR titles (and ideally, commit messages too, although on this repo they get squashed so it doesn't matter that much). I took the liberty of changing the title of this PR myself.

@shleeable
Copy link
Contributor Author

Thanks.

@shleeable shleeable closed this Nov 30, 2022
@shleeable shleeable deleted the patch-4 branch November 30, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants