Change confirm prompt for relationships management #19411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribela
force-pushed
the
relationships-messages
branch
from
fb47e6a
to
091b8a9
Compare
ykzts
approved these changes
Oct 22, 2022
antimundo
approved these changes
Nov 7, 2022
ineffyble
added
ui
TobyWilkes
suggested changes
Nov 14, 2022
ClearlyClaire
approved these changes
Dec 22, 2022
|
@tribela can you rebase it on latest main? |
tribela
force-pushed
the
relationships-messages
branch
from
2b7692a
to
5163110
Compare
Co-authored-by: TobyWilkes <tobylwilkes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On relationships manager, Just asking same "Are you sure?" for destructive action is not good.
Especially, for mobile interface, User cannot know if they touched different action
It maybe better if "Are you sure to ~~(action) for X users?", But it is fine with confirming with action like "Are you sure to follow selected followers?"