Split up LowPriorityDeliveryWorker from pull queue #20216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has merge conflicts now. |
ineffyble
added
the
deployment
tribela
force-pushed
the
split-lowdelivery-queue
branch
from
07fa1a2
to
2589b39
Compare
|
Should this be included, it also needs adjustments |
tribela
force-pushed
the
split-lowdelivery-queue
branch
from
2589b39
to
6099d0e
Compare
|
Closing this on the assumption that #30150 (which contains all the changes here, and also integrates the review feedback to date) will either be rejected/accepted on behalf of them both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
LowPriorityDeliveryWorkerusingpullqueue. This is grammatically incorrect. And causes high pull queue latency.This PR split that worker into a new queue with lowest priority called
low_deliveryqueue.I tested on my server. And it works fine especially someone deleted their account (It causes timeline stop before)