Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'private' to Cache-Control, match Rails expectations #20608

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Add 'private' to Cache-Control, match Rails expectations #20608

merged 1 commit into from
Nov 16, 2022

Commits on Nov 14, 2022

  1. Add 'private' to Cache-Control, match Rails expectations 

    Several controlers set quite intricate Cache-Control headers in order to
hopefully not be cached by any intermediate proxies or local caches. Unfortunately,
these headers are processed by ActionDispatch::HTTP::Cache in a way that squashes
and discards any values set alongside no-store other than private:
https://github.com/rails/rails/blob/8015c2c2cf5c8718449677570f372ceb01318a32/actionpack/lib/action_dispatch/http/cache.rb#L207-L209

We want to preserve no-store on these responses, but we might as well remove
parts that are going to be dropped anyway. As many of the endpoints in these
controllers are private to a particular user, we should also add "private",
which will be preserved alongside no-store.
    @daxtens
    daxtens committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    1260128 View commit details
    Browse the repository at this point in the history