fix disappearing Explore tabs on Safari #20891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nyura123 are you able to log in to CircleCI and give it access to your repo? That will unblock the build-and-test check which is currently pending |
|
@ineffyble sure, let me close this in favor of #20917, where I'm logged into a CircleCI-connected account |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20885.
Wrapping
<span>with<div>done in this PR works, but I don't yet understand why.Other things that work is removing width=100% from the wrapping
<a>or replacing<span>with<div>.Wrapping seemed like the easiest alternative least likely to impact styles elsewhere.