Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate nodeinfo response by schema #21395

Merged
merged 13 commits into from
Dec 15, 2022
Merged

Validate nodeinfo response by schema #21395

merged 13 commits into from
Dec 15, 2022

Commits on Dec 10, 2022

  1. add json-schema to :test in Gemfile

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    648c4e1 View commit details
    Browse the repository at this point in the history

  2. Create node_info_2.0_schema.json

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    93211fc View commit details
    Browse the repository at this point in the history

  3. test match_response_schema

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    b16fbe4 View commit details
    Browse the repository at this point in the history

  4. Create match_response_schema.rb

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    4a85e8d View commit details
    Browse the repository at this point in the history

  5. Update nodeinfo_controller_spec.rb

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    3865efc View commit details
    Browse the repository at this point in the history

  6. Rename spec/support/node_info_2.0_schema.json to spec/support/schema/… 

    …node_info_2.0_schema.json
    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    eb6eae9 View commit details
    Browse the repository at this point in the history

  7. Update match_response_schema.rb

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    36fef70 View commit details
    Browse the repository at this point in the history

  8. cleanup

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    5d0b3b9 View commit details
    Browse the repository at this point in the history

  9. additionally validate the json schema itself 

    disable throwing errors

test the schema matcher
    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    173045b View commit details
    Browse the repository at this point in the history

  10. rename nodeinfo schema to nodeinfo_2.0

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    450e7f8 View commit details
    Browse the repository at this point in the history

  11. use Rails.root.join to construct the path

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    edd0c08 View commit details
    Browse the repository at this point in the history

  12. prettify json

    @MFTabriz
    MFTabriz authored and meisam committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    6bfe842 View commit details
    Browse the repository at this point in the history

  13. sync Gemfile.lock

    @MFTabriz
    MFTabriz committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    89ee9f6 View commit details
    Browse the repository at this point in the history