Hides superluous details on small screens #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashfurrow
commented
Apr 19, 2017
| @@ -1,7 +1,6 @@ | |||
| import { Link } from 'react-router'; | |||
|
|
|||
| const outerStyle = { | |||
| display: 'block', | |||
There was a problem hiding this comment.
This is what I wasn't clear on; I don't know why the style is inline but I had to move the display property to CSS to be able to override it from within the stylesheet. If more/all of these should be moved over, or if there's a better way to do any of this, let me know 👍
Gargron
requested changes
Apr 21, 2017
|
|
||
| &:hover { | ||
| background: lighten($color1, 11%); | ||
| } | ||
|
|
||
| &.hidden-on-mobile { | ||
| @media screen and (max-width: 600px) { |
There was a problem hiding this comment.
The "mobile" layout begins at 1024px, atm.
Gargron
approved these changes
Apr 21, 2017
|
Thanx guys :-) |
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 28, 2017
* Hides superluous details on small screans. * Addressed feedback from mastodon#2175.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #2116 . It removes the "Getting Started" column header, and local/federated timeline links, on mobile. I'll add some comments inline in the PR looking for clarifications or further follow-up.
Before:
After:
Fixes #2072.