Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy address button to account header #21761

Closed
wants to merge 1 commit into from

Conversation

pera
Copy link

@pera pera commented Nov 27, 2022

This PR adds a copy address button next to the address in the account header:

1

If the the account is locked the lock icon is listed first:

2

In case you wonder how it would look with the icons swapped:

3

@connorshea
Copy link
Contributor

Should note that this resolves #21074 and #19850

@pera
Copy link
Author

pera commented Nov 27, 2022

Another font-awesome icon that could work is fa-clipboard:
image

@ClearlyClaire
Copy link
Contributor

Hi! Thank you for your contribution! It's a useful feature, although I'm not completely satisfied with how it looks when an account is locked… unfortunately, I don't have a better suggestion.

I also wonder if #21479 wouldn't be enough here in making the handle easier to copy.

@pera
Copy link
Author

pera commented Dec 2, 2022

Thanks very much for the feedback @ClearlyClaire, and I agree with your comment: having both an icon and an icon-button next to each other can be confusing. The only idea that comes to my mind right now would be to remove the lock icon from its current location:

  1. The meaning of the lock icon differs between Mastodon and other social networks, so as an UI element it can be misleading
  2. If a user wants to follow someone the attention goes to the Follow button (not the address)
  3. The copy button pattern is quite standard nowadays and introducing this functionality would improve the UX on mobile

I propose then to update the "Follow" button to something like "Send follow request" when the account requires follow requests.

Cheers!

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Member

@Gargron Gargron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember talking with you about this in Discord, but I would like to use the UX pattern established by e.g. DigitalOcean and Hetzner for copying IP addresses on screen, and avoid adding another icon to that space. You should be able to click the string to have it copied to the clipboard, with a "Copied" message appearing shortly.

@mjankowski
Copy link
Contributor

Closing due to lack of activity for ~1 year, and different direction chosen from most recent comment.

If you want to push this forward and re-open, can you rebase it, and then do the copy-on-click approach instead of the icon?

@mjankowski mjankowski closed this Dec 1, 2023
@pera
Copy link
Author

pera commented Jan 1, 2024

@mjankowski sorry I just saw this - tbh the current select-on-click functionality is enough for me as a user, but if you still think this could improve the UX I would be happy to rebase and make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants