-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy address button to account header #21761
Conversation
Hi! Thank you for your contribution! It's a useful feature, although I'm not completely satisfied with how it looks when an account is locked… unfortunately, I don't have a better suggestion. I also wonder if #21479 wouldn't be enough here in making the handle easier to copy. |
Thanks very much for the feedback @ClearlyClaire, and I agree with your comment: having both an icon and an icon-button next to each other can be confusing. The only idea that comes to my mind right now would be to remove the lock icon from its current location:
I propose then to update the "Follow" button to something like "Send follow request" when the account requires follow requests. Cheers! |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember talking with you about this in Discord, but I would like to use the UX pattern established by e.g. DigitalOcean and Hetzner for copying IP addresses on screen, and avoid adding another icon to that space. You should be able to click the string to have it copied to the clipboard, with a "Copied" message appearing shortly.
Closing due to lack of activity for ~1 year, and different direction chosen from most recent comment. If you want to push this forward and re-open, can you rebase it, and then do the copy-on-click approach instead of the icon? |
@mjankowski sorry I just saw this - tbh the current select-on-click functionality is enough for me as a user, but if you still think this could improve the UX I would be happy to rebase and make the changes. |
This PR adds a copy address button next to the address in the account header:
If the the account is locked the lock icon is listed first:
In case you wonder how it would look with the icons swapped: