Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Verifyable link to new account after profile moved #21844

Closed
wants to merge 1 commit into from
Closed

Fix regression: Verifyable link to new account after profile moved #21844

wants to merge 1 commit into from

Conversation

yetzt
Copy link

@yetzt yetzt commented Nov 29, 2022

See issue #21845

@@ -23,7 +23,7 @@ export default class MovedNote extends ImmutablePureComponent {
</div>

<div className='moved-account-banner__action'>
<Link to={`/@${to.get('acct')}`} className='detailed-status__display-name'>
<Link rel='me' href={to.get('url')} to={`/@${to.get('acct')}`} className='detailed-status__display-name'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The to= property already renders a href and I doubt multiple href are allowed. Also this entire component is not rendered serverside, so the resulting HTML contains neither the link nor your fixed version of it. I don't think this will work.

Copy link
Contributor

@untitaker untitaker Nov 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you likely want to patch this file instead (or possibly in addition): https://github.com/mastodon/mastodon/blob/main/app/views/accounts/show.html.haml#L8-L9

@ClearlyClaire
Copy link
Contributor

ClearlyClaire commented Dec 1, 2022

Hi! Have you verified this would fix your issue? I don't think that's related to the Permalink change, but to the earlier redesign where we dropped server-side-rendered pages in favor of the React app (#19319). Indeed, before that, the server-side-rendered banner included a rel="me noopener noreferrer" link to the new account, but the new does not include any such thing.

Your proposal would have an appropriate rel="me" link in the client-side rendered DOM, but that's not what Mastodon checks to decide if the link is verified.

@yetzt
Copy link
Author

yetzt commented Dec 1, 2022

i haven't verified anything and i'm not too familiar with the mastodon codebase. maybe someone with a better understanding of the codebase could ensure a verifyable link to a transferred profile could be included in the delivered html of a profile page if an account is transferred.

@yetzt yetzt closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants